[
https://issues.apache.org/jira/browse/ARTEMIS-5863?focusedWorklogId=1002685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1002685
]
ASF GitHub Bot logged work on ARTEMIS-5863:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/26 14:30
Start Date: 30/Jan/26 14:30
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #6201:
URL: https://github.com/apache/artemis/pull/6201#discussion_r2746582265
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImplTest.java:
##########
@@ -3042,6 +3044,13 @@ public void testExportInvalidPropertyOnAcceptor() throws
Exception {
configuration.addAcceptorConfiguration("test",
"tcp://0.0.0.0:61616?useKQueue");
File fileOutput = new File(getTestDirfile(), "broker.properties");
assertDoesNotThrow(() -> configuration.exportAsProperties(fileOutput));
+ Properties properties = new Properties();
+ try (InputStream inStream = Files.newInputStream(fileOutput.toPath())) {
+ properties.load(inStream);
+ }
+ assertFalse(properties.isEmpty());
+
assertTrue(properties.containsKey("acceptorConfigurations.test.params.useKQueue"));
+ assertEquals("",
properties.get("acceptorConfigurations.test.params.useKQueue"));
Review Comment:
we don't currently have a way to set a null value, it looks like we may need
that to keep this consistent, and export null values as the null string. and
check for it when we set properties and replace it with the null object.
Issue Time Tracking
-------------------
Worklog Id: (was: 1002685)
Time Spent: 1h 50m (was: 1h 40m)
> Configuration export as properties would throw NPE for invalid acceptor URIs
> ----------------------------------------------------------------------------
>
> Key: ARTEMIS-5863
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5863
> Project: Artemis
> Issue Type: Bug
> Affects Versions: 2.50.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.51.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> say you specify the following URI:
> configuration.addAcceptorConfiguration("test",
> "tcp://0.0.0.0:61616?useKQueue");
> useKQueue would generate a null value on the HashMap, which would throw a NPE
> during export.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
