gtully commented on code in PR #6199:
URL: https://github.com/apache/artemis/pull/6199#discussion_r2736651704
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java:
##########
@@ -1105,10 +1105,12 @@ private void export(BeanUtilsBean beanUtils,
Stack<String> nested, BufferedWrite
stream = stream.filter((Map.Entry<?, ?> entry)->
filterOn.isAssignableFrom(entry.getClass()));
}
stream.forEach(entry -> {
- // nested by name
- nested.push(entry.getKey().toString());
- export(beanUtils, nested, bufferedWriter, entry.getValue());
- nested.pop();
+ if (entry.getValue() != null) {
Review Comment:
this is inconsistent. the check for null to not export a key with for a null
value
and the use of String.ValueOf that will write key="null" for a null value.
we should be consistent and write key= for null values and not introduce
"null" as we don't understand that as a config value.
This means we need to check for a null value and write an empty string ''
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
