[
https://issues.apache.org/jira/browse/ARTEMIS-5850?focusedWorklogId=1001172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1001172
]
ASF GitHub Bot logged work on ARTEMIS-5850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/26 13:31
Start Date: 21/Jan/26 13:31
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #158:
URL: https://github.com/apache/artemis-console/pull/158#discussion_r2712573980
##########
pom.xml:
##########
@@ -126,6 +127,23 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.commonjava.maven.plugins</groupId>
+ <artifactId>directory-maven-plugin</artifactId>
+ <version>1.0</version>
+ <executions>
+ <execution>
+ <id>directories</id>
+ <goals>
+ <goal>highest-basedir</goal>
+ </goals>
+ <phase>initialize</phase>
+ <configuration>
+ <property>root.basedir</property>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review Comment:
Looking at the plugin repo it seems to be dead, with issues and PR reported
3 years ago and either not merged or not release, and people noting they have
forked it. I dont think we need a plugin execution just for what this is doing
(we could use a path relative to other known props like the builddir or pom
root dir), but I'd be reluctant to start using this one either way. I believe
Maven 4 has some new props around this kind of thing too, so if goign for a
simple prop I expect we can tidy it up more when we start using that.
(Would have otherwise said, plugin version should be managed or at least a
property)
##########
artemis-console-website/pom.xml:
##########
@@ -0,0 +1,103 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.artemis</groupId>
+ <artifactId>artemis-console-project</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>artemis-console-website</artifactId>
+ <packaging>jar</packaging>
+ <name>Apache Artemis Console Website</name>
+
+ <properties>
+ <!
Issue Time Tracking
-------------------
Worklog Id: (was: 1001172)
Time Spent: 1.5h (was: 1h 20m)
> Consolidate web console docs
> ----------------------------
>
> Key: ARTEMIS-5850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5850
> Project: Artemis
> Issue Type: Task
> Components: Documentation
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently documentation for the web console is in 2 places:
> *
> https://github.com/apache/artemis-website/tree/main/src/components/artemis-console/documentation
> *
> https://github.com/apache/artemis/blob/main/docs/user-manual/management-console.adoc
> Each set of documentation has information that the other set doesn't as well
> as significant overlap. This documentation should be consolidated with a
> preference for the AsciiDoc format since it's superior to Markdown in this
> context.
> Also, the docs needs to be updated to account for new functionality and
> behavior introduced in recent versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
