paleolimbot opened a new issue, #938:
URL: https://github.com/apache/arrow-nanoarrow/issues/938

   Found by Codex when reviewing 
https://github.com/apache/arrow-nanoarrow/pull/930
   
   The offending narrowing cast is:
   
   ```c
     if (private_data->storage_type == NANOARROW_TYPE_STRING_VIEW ||
         private_data->storage_type == NANOARROW_TYPE_BINARY_VIEW) {
       struct ArrowBuffer* data_buffer = ArrowArrayBuffer(array, 1);
       union ArrowBinaryView bvt;
       bvt.inlined.size = (int32_t)value.size_bytes;
   
       if (value.size_bytes <= NANOARROW_BINARY_VIEW_INLINE_SIZE) {
         memcpy(bvt.inlined.data, value.data.as_char, value.size_bytes);
         memset(bvt.inlined.data + bvt.inlined.size, 0,
                NANOARROW_BINARY_VIEW_INLINE_SIZE - bvt.inlined.size);
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to