[ 
https://issues.apache.org/jira/browse/ARROW-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873625#comment-16873625
 ] 

Benjamin Kietzman commented on ARROW-5744:
------------------------------------------

[~wesmckinn] [~brillsp]

Could you clarify what should happen? Concatenate already raises an error if 
concatenation of BinaryArrays (or ListArrays) would result in an offset over 
INT_MAX: 

https://github.com/apache/arrow/blob/master/cpp/src/arrow/array/concatenate-test.cc#L215-L224


WRT https://github.com/apache/arrow/pull/4598#issuecomment-504120539

The 2GB limit is a limitation of resulting from using int32_t offsets to 
delimit the strings in a character buffer, so even if concatenate were to 
produce a character buffer larger than 2GB offsets for viewing that much string 
data could not be represented in int32_t

> [C++] arrow::Concatenate does not check for BinaryArray offset overflows
> ------------------------------------------------------------------------
>
>                 Key: ARROW-5744
>                 URL: https://issues.apache.org/jira/browse/ARROW-5744
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Benjamin Kietzman
>            Priority: Critical
>             Fix For: 0.14.0
>
>
> Discovered during ARROW-5635 code review



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to