[ 
https://issues.apache.org/jira/browse/ARROW-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871525#comment-16871525
 ] 

Wes McKinney commented on ARROW-5712:
-------------------------------------

OK, so the offending section in question is:

https://github.com/apache/arrow/blob/master/cpp/src/parquet/parquet.thrift#L332

{code}
  // use ConvertedType TIME_MICROS for TIME(isAdjustedToUTC = true, unit = 
MICROS)
  // use ConvertedType TIME_MILLIS for TIME(isAdjustedToUTC = true, unit = 
MILLIS)
  7:  TimeType TIME

  // use ConvertedType TIMESTAMP_MICROS for TIMESTAMP(isAdjustedToUTC = true, 
unit = MICROS)
  // use ConvertedType TIMESTAMP_MILLIS for TIMESTAMP(isAdjustedToUTC = true, 
unit = MILLIS)
  8:  TimestampType TIMESTAMP
{code}

What does {{isAdjustedToUTC}} even mean for time types? Presently we have no 
way of generating the "true" case for time types from the Arrow API.


> [C++][Parquet] Arrow time32/time64/timestamp ConvertedType not being restored 
> properly
> --------------------------------------------------------------------------------------
>
>                 Key: ARROW-5712
>                 URL: https://issues.apache.org/jira/browse/ARROW-5712
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++, Python
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>             Fix For: 1.0.0
>
>
> These values are currently being written as raw INT32 without a logical or 
> converted type set
> Example statistics for {{time32('ms')}} with {{version='2.0'}} set
> {code}
> (Pdb) stats
> <pyarrow._parquet.Statistics object at 0x7f6a9dca9f30>
>   has_min_max: True
>   min: 37800001
>   max: 55800001
>   null_count: 0
>   distinct_count: 0
>   num_values: 2
>   converted_type: NONE
>   physical_type: INT32
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to