[
https://issues.apache.org/jira/browse/ARROW-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433683#comment-16433683
]
ASF GitHub Bot commented on ARROW-2224:
---------------------------------------
pitrou commented on issue #1880: ARROW-2224: [C++] Remove boost-regex dependency
URL: https://github.com/apache/arrow/pull/1880#issuecomment-380401339
Reverted the `std::isdigit` change because of a silly performance warning
(turned into an error) on MSVC. It's not like `isdigit` is more readable
anyway, and apparently it risks being locale-dependent on Windows (which is a
can of worms).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Replace boost regex usage with libre2
> -------------------------------------------
>
> Key: ARROW-2224
> URL: https://issues.apache.org/jira/browse/ARROW-2224
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Priority: Major
> Labels: pull-request-available
>
> We're using {{boost::regex}} to parse decimal strings for {{decimal128}}
> types. We should use {{libre2}} instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
