[ 
https://issues.apache.org/jira/browse/ARTEMIS-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018065#comment-18018065
 ] 

Grzegorz Grzybek commented on ARTEMIS-5649:
-------------------------------------------

https://github.com/hawtio/hawtio/commit/bf21afe9d1 fixed an issue with Hawtio 
where the WAR was deployed under different context path than {{/hawtio}}.
This commit fixed https://github.com/hawtio/hawtio/issues/3885 issue which was 
created after _temporary fix_ for 
https://issues.apache.org/jira/browse/ARTEMIS-5440

Artemis Console WAR has {{index.html}} where the base href is already changed 
(by webpack) to:
{code:html}
<base href="/console/"/>
{code}

So you're not seeing any change, but if you change context path for Jetty in 
Artemis for the console.war, you'll see that it's in fact needed.

> Remove BaseTagHrefFilter
> ------------------------
>
>                 Key: ARTEMIS-5649
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5649
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>          Components: Web Console
>    Affects Versions: console-1.3.0
>            Reporter: Gašper Čefarin
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> While looking at HPKP header I also came across hawtio's BaseTagHrefFilter, 
> but in my tests it doesn't seem to be necessary.
> I tested this via mvn jetty:run, and by deleting the filter from web.xml on 
> an existing installation of artemis broker v2.41.0.
> It works in both cases.
> Maybe [~ggrzybek] can confirm that this is indeed unnecessary.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to