[
https://issues.apache.org/jira/browse/ARTEMIS-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grzegorz Grzybek updated ARTEMIS-5577:
--------------------------------------
Description:
I've [just
committed|https://github.com/hawtio/hawtio-next/commit/dec591c828a16618e0e4653882ec7a51ad244e9f]
a lot of changes to {{@hawtio/react}} NPM package for better dependency
handling.
There's special dev document here:
https://github.com/hawtio/hawtio-next/blob/main/app/README.md
This document clearly (I hope) describes what should be included in these
package.json fields:
* dependencies
* devDependencies
* peerDependencies
{{@hawtio/react}} is a package which should be treated as _plugin_ for React
and PatternFly libraries. It is also used by {{artemis-console-plugin}} NPM
package, which also should be treated as a plugin.
This means that Patternfly and React should be _peer dependencies_ to be
managed at _application level_ (by _application_ I mean NPM package which is
not intended to be published to NPM and which is bundled by _final_ bundler
like Webpack).
was:
I've [just
committed|https://github.com/hawtio/hawtio-next/commit/dec591c828a16618e0e4653882ec7a51ad244e9f]
a lot of change to {{@hawtio/react}} NPM package for better dependency
handling.
There's special dev document here:
https://github.com/hawtio/hawtio-next/blob/main/app/README.md
This document clearly (I hope) describes what should be included in these
package.json fields:
* dependencies
* devDependencies
* peerDependencies
{{@hawtio/react}} is a package which should be treated as _plugin_ for React
and PatternFly libraries. It is also used by {{artemis-console-plugin}} NPM
package, which also should be treated as a plugin.
This means that Patternfly and React should be _peer dependencies_ to be
managed at _application level_ (by _application_ I mean NPM package which is
not intended to be published to NPM and which is bundled by _final_ bundler
like Webpack).
> Correct separation of dev, normal and peer dependencies in the console
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-5577
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5577
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Web Console
> Reporter: Grzegorz Grzybek
> Priority: Major
>
> I've [just
> committed|https://github.com/hawtio/hawtio-next/commit/dec591c828a16618e0e4653882ec7a51ad244e9f]
> a lot of changes to {{@hawtio/react}} NPM package for better dependency
> handling.
> There's special dev document here:
> https://github.com/hawtio/hawtio-next/blob/main/app/README.md
> This document clearly (I hope) describes what should be included in these
> package.json fields:
> * dependencies
> * devDependencies
> * peerDependencies
> {{@hawtio/react}} is a package which should be treated as _plugin_ for React
> and PatternFly libraries. It is also used by {{artemis-console-plugin}} NPM
> package, which also should be treated as a plugin.
> This means that Patternfly and React should be _peer dependencies_ to be
> managed at _application level_ (by _application_ I mean NPM package which is
> not intended to be published to NPM and which is bundled by _final_ bundler
> like Webpack).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
