[
https://issues.apache.org/jira/browse/IMPALA-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116213#comment-18116213
]
ASF subversion and git services commented on IMPALA-15362:
----------------------------------------------------------
Commit a51ab1940108c3be9a5564b5045fe86773399731 in impala's branch
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a51ab1940 ]
IMPALA-15362: Remove dead code after IMPALA-2764
Removes undef.cpp, which was only needed when libsasl2 was statically
linked. After IMPALA-2764 it's dynamically linked and undef.cpp is no
longer necessary.
Fixes thrift-server-test with the 'mold' linker, where the symbols
in undef.cpp would cause conflicts.
Change-Id: I2ec2bb9854151f1177e7022cd409733564673675
Reviewed-on: http://gerrit.cloudera.org:8080/24866
Reviewed-by: Csaba Ringhofer <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
Tested-by: Michael Smith <[email protected]>
> Dead-code cleanup after IMPALA-2765
> -----------------------------------
>
> Key: IMPALA-15362
> URL: https://issues.apache.org/jira/browse/IMPALA-15362
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Michael Smith
> Assignee: Michael Smith
> Priority: Major
>
> [https://github.com/apache/impala/blob/ffa7829/be/src/transport/undef.cpp]
> notes it can be removed after IMPALA-2765 is fixed, which was done in Impala
> 2.5.0. It should essentially be dead code. However the {{mold}} linker
> handles it slightly differently, so let's remove it to fix thrift-server-test
> when linked with {{{}mold{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
