[
https://issues.apache.org/jira/browse/IMPALA-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18061045#comment-18061045
]
ASF subversion and git services commented on IMPALA-14777:
----------------------------------------------------------
Commit 554cc2bbccd932ea057440c9c0762b3522993d0c in impala's branch
refs/heads/master from Marton Greber
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=554cc2bbc ]
IMPALA-14777: Sync dynamic_annotations from Kudu
be/src/gutil/dynamic_annotations.h was missing Kudu commit a964b0e36
("gutil: properly hook up ANNOTATE_HAPPENS_BEFORE/AFTER", Feb 2018),
which fixed ANNOTATE_HAPPENS_BEFORE and ANNOTATE_HAPPENS_AFTER to use
the proper AnnotateHappensBefore/AnnotateHappensAfter TSAN runtime
functions instead of the condvar-based equivalents.
Also adds the corresponding AnnotateHappensBefore/AnnotateHappensAfter
stub implementations to dynamic_annotations.c, which were missing the
non-TSAN fallback definitions needed when
DYNAMIC_ANNOTATIONS_EXTERNAL_IMPL=0.
Testing: data-stream-test was reporting a TSAN data race on
SignalData::stack in debug-util.cc due to the annotations being
effectively no-ops. Running the test under TSAN with this patch applied
shows the race no longer appears.
Change-Id: I70eda4515cb5e9aed835c371ed3b473e6a9c3ea6
Reviewed-on: http://gerrit.cloudera.org:8080/24030
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Sync dynamic annotation from Kudu
> ---------------------------------
>
> Key: IMPALA-14777
> URL: https://issues.apache.org/jira/browse/IMPALA-14777
> Project: IMPALA
> Issue Type: Bug
> Reporter: Marton Greber
> Priority: Minor
>
> KUDU-3735 reported a data race when running data-stream-test, origination
> from Kudu's debug utils.
> After some digging I've noticed that Impala has some older
> ANNOTATE_HAPPENS_BEFORE and ANNOTATE_HAPPENS_AFTER defs.
> In be/src/gutil is basically missing
> [https://github.com/apache/kudu/commit/a964b0e36c7bb16bdbbd7f8aa98c67e1da5a99eb#diff-f527ea47189599b486e1f32114af819d1a59ce2debd770fbc79b5b746fd794c7]
> By updating the annotations I've checked that the tsan report goes away.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
