[
https://issues.apache.org/jira/browse/IMPALA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18038814#comment-18038814
]
ASF subversion and git services commented on IMPALA-14552:
----------------------------------------------------------
Commit 898e03e9d5dd9aa43494e4ffd93063beebf6885b in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=898e03e9d ]
IMPALA-14552: (addendum) Fix bad testcase in show-create-table.test
The original IMPALA-14552 patch pass precommit tests before
IMPALA-12893: (part 2) (275f03f) merged. As consequence, it does not
catch missing comma in updated show-create-table.test. This patch add
that missing comma.
Testing:
Pass metadata/test_show_create_table.py
Change-Id: Ib06e690a81e6b0ca483b3647cc59c73802a0a7b7
Reviewed-on: http://gerrit.cloudera.org:8080/23673
Reviewed-by: Riza Suminto <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> test_show_create_table should be more strict with TBLPROPERTIES contents
> ------------------------------------------------------------------------
>
> Key: IMPALA-14552
> URL: https://issues.apache.org/jira/browse/IMPALA-14552
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
>
> Currently we use this regex to parse the contents of TBLPROPERTIES:
> {noformat}
> kv_regex = "'([^\']+)'\\s*=\\s*'([^\']+)'"
> kv_results = dict(re.findall(kv_regex, map_match.group(1))){noformat}
> This allows strings like:
> {noformat}
> 'X'='Y'='Z'
> 'X'='Z'$'A'='B'{noformat}
> This means it's easy to write strings in .test files that are not valid SQL.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
