[
https://issues.apache.org/jira/browse/IMPALA-14403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020584#comment-18020584
]
ASF subversion and git services commented on IMPALA-14403:
----------------------------------------------------------
Commit 2efd22bd73f50fe77249dabb4f1ae551e5fe7bbe in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=2efd22bd7 ]
IMPALA-14403: Fix OpenTelemetry TLS Detection
Fixes the code that detects if the OpenTelemetry collector is using
TLS. Previously, the code only worked properly when the collector URL
was all lowercase. Also removes unnecessary checks that could cause
TLS to be enabled even when the collector URL scheme was not https.
Testing accomplished by adding new ctest tests.
Change-Id: I3bf74f1353545d280575cdb94cf135e55c580ec7
Reviewed-on: http://gerrit.cloudera.org:8080/23397
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> OTel Tracing TLS Enabled
> ------------------------
>
> Key: IMPALA-14403
> URL: https://issues.apache.org/jira/browse/IMPALA-14403
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 5.0.0
> Reporter: Jason Fehr
> Assignee: Jason Fehr
> Priority: Critical
>
> [The code that
> detects|https://github.com/apache/impala/blob/e486f3e3c38df373980fe928a9895b10c3c79a75/be/src/observe/otel.cc#L141]
> whether or not https is enabled on the OTel collector has a bug -- it does a
> case sensitive compare of the otel_trace_collector_url. That means
> specifying a URL such as 'HTTPS://example.com/collector' will not have the
> OTel client's TLS properly configured.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
