[
https://issues.apache.org/jira/browse/IMPALA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017945#comment-18017945
]
ASF subversion and git services commented on IMPALA-14314:
----------------------------------------------------------
Commit 789991c6cc01819e93521cb9d7703c9a2ec58ce4 in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=789991c6c ]
IMPALA-13237: [Patch 8] - OpenTelemetry Traces for DML/DDL Queries and Handle
Leading Comments
Trace DML/DDL Queries
* Adds tracing for alter, compute, create, delete, drop, insert,
invalidate metadata, and with queries.
* Stops tracing beeswax queries since that protocol is deprecated.
* Adds Coordinator attribute to Init and Root spans for identifying
where the query is running.
Comment Handling
* Corrects handling of leading comments, both inline and full line.
Previously, queries with comments before the first keyword were
always ignored.
* Adds be ctest tests for determining whether or not a query should
be traced.
General Improvements
* Handles the case where the first query keyword is followed by a
newline character or an inline comment (without or with spaces
between).
* Corrects traces for errored/cancelled queries. These cases
short-circuit the normal query processing code path and have to be
handled accordingly.
* Ends the root span when the query ends instead of waiting for the
ClientRequestState to go out of scope. This change removes
use-after-free issues caused by reading from ClientRequestState
when the SpanManager went out of scope during that object's dtor.
* Simplified minimum tls version handling because the validators
on the ssl_minimum_version eliminate invalid values that previously
had to be accounted for.
* Removes the unnecessary otel_trace_enabled() function.
* Fixes IMPALA-14314 by waiting for the full trace to be written to
the output file before asserting that trace.
Testing
* Full test suite passed.
* ASAN/TSAN builds passed.
* Adds new ctest test.
* Adds custom cluster tests to assert traces for the new supported
query types.
* Adds custom cluster tests to assert traces for errored and
cancelled queries.
Generated-by: Github Copilot (Claude Sonnet 3.7)
Change-Id: Ie9e83d7f761f3d629f067e0a0602224e42cd7184
Reviewed-on: http://gerrit.cloudera.org:8080/23279
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Riza Suminto <[email protected]>
> Failure in TestOtelTrace.test_retry_select_failed
> -------------------------------------------------
>
> Key: IMPALA-14314
> URL: https://issues.apache.org/jira/browse/IMPALA-14314
> Project: IMPALA
> Issue Type: Bug
> Reporter: Daniel Becker
> Assignee: Jason Fehr
> Priority: Major
>
> Some internal builds fail in TestOtelTrace.test_retry_select_failed:
> h3. Error Message
> {noformat}
> AssertionError: File
> '/data/jenkins/workspace/impala-cdw-master-staging-core-s3-arm-data-cache/repos/Impala/logs/custom_cluster_tests/impala_test_out_dir_Phd6Zz/export-trace.jsonl'
> did not reach expected line count of '3'. actual line count: '4'{noformat}
> h3. Stacktrace
> {noformat}
> custom_cluster/test_otel_trace.py:164: in test_retry_select_failed
> err_span="QueryExecution")
> custom_cluster/test_otel_trace.py:232: in __assert_trace
> backoff=1)
> common/file_utils.py:221: in wait_for_file_line_count
> .format(file_path, expected_line_count, count_lines(file_path))
> E AssertionError: File
> '/data/jenkins/workspace/impala-cdw-master-staging-core-s3-arm-data-cache/repos/Impala/logs/custom_cluster_tests/impala_test_out_dir_Phd6Zz/export-trace.jsonl'
> did not reach expected line count of '3'. actual line count: '4'{noformat}
> The test was recently added here: [https://gerrit.cloudera.org/#/c/22924/]
> @Jason Fehr could you take a look?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
