[
https://issues.apache.org/jira/browse/IMPALA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017707#comment-18017707
]
Jason Fehr commented on IMPALA-14371:
-------------------------------------
Suggestion from [~arawat]
[link|https://gerrit.cloudera.org/c/23279/26/be/src/observe/otel.cc#125]:
This could potentially be optimized further, basically avoiding regex and
multiple conversions and comparisons using boost (even though short circuited):
find the first keyword and convert to lowercase once
compare the keyword against a unordered_map of allowed keywords
> OTel Trace Queries Improvements
> -------------------------------
>
> Key: IMPALA-14371
> URL: https://issues.apache.org/jira/browse/IMPALA-14371
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Jason Fehr
> Priority: Critical
>
> The code in otel.cc to detect whether or not a query should be traced is
> brittle with lots of corner cases. For example, if there are comments at the
> beginning or immediately after the first keyword, the query may not get
> traced.
> Research and implement a better way of determining if queries should or
> should not be traced.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
