[
https://issues.apache.org/jira/browse/IMPALA-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016506#comment-18016506
]
ASF subversion and git services commented on IMPALA-14359:
----------------------------------------------------------
Commit fd9de7a2e16e72f244b9bfa15a71efe16a5c01ac in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=fd9de7a2e ]
IMPALA-14348: Fix TSAN issue after IMPALA-14327
IMPALA-14327 reveal TSAN issue in impala-hs2-server.cc.
ClientRequestState::returns_result_set() was accessed without holding
ClientRequestState::lock_ in impala-hs2-server.cc.
This patch fix the issue by obtaining ClientRequestState::lock_ first
before accessing ClientRequestState::returns_result_set() and
ClientRequestState::result_metadata(). Both accesses are done inside
ImpalaServer::SetupResultsCacheing so lock_ only need to be obtained
once. Filed IMPALA-14359 to follow up investigation.
Testing:
Run and pass TSAN build.
Change-Id: I41fc25cea5b4ef7b4b9daac54b8665fa76ceb1cd
Reviewed-on: http://gerrit.cloudera.org:8080/23343
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Investigate race situation in ExecuteStatement vs ExecDdlRequestImpl
> --------------------------------------------------------------------
>
> Key: IMPALA-14359
> URL: https://issues.apache.org/jira/browse/IMPALA-14359
> Project: IMPALA
> Issue Type: Task
> Reporter: Riza Suminto
> Priority: Major
>
> IMPALA-14348 reveals a data race between ImpalaServer::ExecuteStatement
> (ExecuteStatementCommon) vs async ClientRequestState::ExecDdlRequestImpl on
> ClientRequestState::result_metadata_. While it can be solved by acquiring CRS
> lock in impala-hs2-server.cc, further investigation is needed since having
> ClientRequestState::ExecDdlRequestImpl finished ahead of
> ImpalaServer::ExecuteStatement might be abnormal and incorrectly handled.
> This Jira is filed to follow up with that investigation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
