[
https://issues.apache.org/jira/browse/IMPALA-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mihaly Szjatinya resolved IMPALA-13912.
---------------------------------------
Resolution: Fixed
> Use SHARED_CLUSTER_ARGS in more custom cluster tests
> ----------------------------------------------------
>
> Key: IMPALA-13912
> URL: https://issues.apache.org/jira/browse/IMPALA-13912
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Csaba Ringhofer
> Assignee: Mihaly Szjatinya
> Priority: Minor
> Labels: ramp-up
>
> IMPALA-13503 allowed restarting the cluster only once per test suite in
> CustomClusterTestSuites using per suite @CustomClusterTestSuite.with_args.
> There are many custom cluster tests that could be restructured to be much
> faster this way, for example
> https://github.com/apache/impala/blob/7f38c7ed61a0536c430311b3d4600aa0a16b988a/tests/custom_cluster/test_client_ssl.py#L100C7-L100C15
> {code}
> @CustomClusterTestSuite.with_args(impalad_args=SSL_ARGS,
> statestored_args=SSL_ARGS,
> catalogd_args=SSL_ARGS)
> def test_ssl(self, vector):
> {code}
> The test above is run with 4 test vectors (see add_test_dimensions) and the
> cluster is restarted each time. This is not needed as the test vector doesn't
> affect the cluster parameters. A possible fix for this is to split the test
> suite to multiple suites where CustomClusterTestSuite.with_args is set per
> suite instead of per test.
> Tests like this seem very common - the following rough estimate returns 189:
> {code}
> git grep -B5 "def test.*vector" | grep "CustomClusterTestSuite.with_args" |
> wc -l
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
