[
https://issues.apache.org/jira/browse/IMPALA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014921#comment-18014921
]
ASF subversion and git services commented on IMPALA-13444:
----------------------------------------------------------
Commit c23d3cb58adc558fe5e5064f9db6f6471c18d4ea in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c23d3cb58 ]
IMPALA-14311: Fix ASAN issue in test_query_cancel_load_tables
verifiers.test_verify_metrics.TestValidateMetrics.test_metrics_are_zero
fails in ASAN tests. This is because a client session opened by
test_query_cancel_load_tables is not cleanly closed.
This patch fix the issue by creating the Impala client within the run
method of web_pages_util.py using with-as statement.
This patch also attempt to fix flakiness in test_query_expiration by
validating that time_limit_expire_handle is actually closed in
Coordinator log (IMPALA-13444).
Testing:
- Pass test_web_pages.py test in ASAN build.
- Loop and pass test_query_expiration 50x in ASAN build.
Change-Id: I6fcf13902478535f6fa15f267edc83891057993c
Reviewed-on: http://gerrit.cloudera.org:8080/23302
Reviewed-by: Daniel Becker <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> test_query_expiration failed with unexpected number of queries waiting
> ----------------------------------------------------------------------
>
> Key: IMPALA-13444
> URL: https://issues.apache.org/jira/browse/IMPALA-13444
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.5.0
> Reporter: Joe McDonnell
> Assignee: Michael Smith
> Priority: Critical
> Labels: broken-build, flaky
>
> This symptom showed up on ARM ASAN run:
> {noformat}
> custom_cluster/test_query_expiration.py:114: in test_query_expiration
> self._check_num_executing(impalad, 2)
> custom_cluster/test_query_expiration.py:45: in _check_num_executing
> assert waiting == expect_waiting, '%s out of %s queries waiting (expected
> %s)' \
> E AssertionError: 1 out of 3 queries waiting (expected 0)
> E assert 1 == 0{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
