[
https://issues.apache.org/jira/browse/IMPALA-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013327#comment-18013327
]
ASF subversion and git services commented on IMPALA-14165:
----------------------------------------------------------
Commit 922443da463f64443d7796fb1fb3435a6f513e83 in impala's branch
refs/heads/master from Steve Carlin
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=922443da4 ]
IMPALA-14165: Type coercion code accidentally omitted from analysis
On the first cut of creating the Calcite planner, the Calcite planner
was standalone and ran its own JniFrontend.
In the current version, the parsing, validating, and single node
planning is called from the Impala framework.
There is some code in the first cut regarding the
"ImpalaTypeCoercionFactory" class which handles deriving the correct
data type for various expressions, for instance (found in exprs.test):
select count(*) from alltypesagg where
10.1 in (tinyint_col, smallint_col, int_col, bigint_col, float_col, double_col)
Without this patch, the query returns the following error:
UDF ERROR: Decimal expression overflowed
This code can be found in CalciteValidator.java, but was accidentally omitted
from CalciteAnalysisDriver.
Change-Id: I74c4c714504400591d1ec6313f040191613c25d9
Reviewed-on: http://gerrit.cloudera.org:8080/23039
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Steve Carlin <[email protected]>
> Calcite planner: Type coercion code accidentally omitted from Analysis
> ----------------------------------------------------------------------
>
> Key: IMPALA-14165
> URL: https://issues.apache.org/jira/browse/IMPALA-14165
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Steve Carlin
> Assignee: Steve Carlin
> Priority: Major
>
> On the first cut of creating the Calcite planner, the Calcite planner was
> standalone and ran its own JniFrontend.
> In the current version, the parsing, validating, and single node planning is
> called from the Impala framework.
> There is some code in the first cut regarding the "ImpalaTypeCoercionFactory"
> class which handles deriving the correct data type for various expressions,
> for instance (found in exprs.test):
> 10.1 in (tinyint_col, smallint_col, int_col, bigint_col, float_col,
> double_col)
> This code was accidentally omitted in the current version and needs to be
> added.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
