[
https://issues.apache.org/jira/browse/IMPALA-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012055#comment-18012055
]
ASF subversion and git services commented on IMPALA-14214:
----------------------------------------------------------
Commit 19f662301cafc95be59fda261ad4583a48ed4461 in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=19f662301 ]
IMPALA-14214: [Addendum] - Ensure IMPALA_TOOLCHAIN_COMMIT_HASH Matches Build IDs
Adds verification code to ensure the IMPALA_TOOLCHAIN_COMMIT_HASH
environment variable matches the commit hash in the
IMPALA_TOOLCHAIN_BUILD_ID_AARCH64 and
IMPALA_TOOLCHAIN_BUILD_ID_X86_64 environment variables.
Generated-by: Github Copilot (Claude Sonnet 3.7)
Change-Id: I348698356a014413875f6b8b54a005bf89b9793a
Reviewed-on: http://gerrit.cloudera.org:8080/23243
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Compile Toolchain OpenTelemetry SDK Against STDLIB
> --------------------------------------------------
>
> Key: IMPALA-14214
> URL: https://issues.apache.org/jira/browse/IMPALA-14214
> Project: IMPALA
> Issue Type: Improvement
> Components: Toolchain
> Affects Versions: Impala 4.5.0
> Reporter: Jason Fehr
> Assignee: Jason Fehr
> Priority: Major
> Labels: toolchain
>
> The OpenTelemetry C++ SDK has [a
> doc|https://github.com/open-telemetry/opentelemetry-cpp/blob/cafcfaab6c504da80d7f7571814d1f36989db0c7/docs/building-with-stdlib.md]
> about compiling against STDLIB. By default, the SDK compiles against a
> translation layer named "nostd". This additional layer ensures application
> binary interface compatibility which is required when using OpenTelemetry as
> a shared library.
> Since we compile OpenTelemetry as a static library, this additional layer is
> not needed. The OpenTelemetry SDK doc states:
> {noformat}
> Compiling OpenTelemetry SDK from source using standard library classes:
> std::map, std::string_view, std::span, std::variant instead of nostd:: yields
> better performance and debugability at expense of potentially losing ABI
> compatibility.{noformat}
> Since Impala does not need ABI compatibility, we should compile the toolchain
> OpenTelemetry C++ SDK against stdlib.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
