Jason Fehr created IMPALA-14214:
-----------------------------------
Summary: Compile Toolchain OpenTelemetry SDK Against STDLIB
Key: IMPALA-14214
URL: https://issues.apache.org/jira/browse/IMPALA-14214
Project: IMPALA
Issue Type: Improvement
Components: Toolchain
Affects Versions: Impala 4.5.0
Reporter: Jason Fehr
Assignee: Jason Fehr
The OpenTelemetry C++ SDK has [a
doc|https://github.com/open-telemetry/opentelemetry-cpp/blob/cafcfaab6c504da80d7f7571814d1f36989db0c7/docs/building-with-stdlib.md]
about compiling against STDLIB. By default, the SDK compiles against a
translation layer named "nostd". This additional layer ensures application
binary interface compatibility which is required when using OpenTelemetry as a
shared library.
Since we compile OpenTelemetry as a static library, this additional layer is
not needed. The OpenTelemetry SDK doc states:
{noformat}
Compiling OpenTelemetry SDK from source using standard library classes:
std::map, std::string_view, std::span, std::variant instead of nostd:: yields
better performance and debugability at expense of potentially losing ABI
compatibility.{noformat}
Since Impala does not need ABI compatibility, we should compile the toolchain
OpenTelemetry C++ SDK against stdlib.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
