[
https://issues.apache.org/jira/browse/IMPALA-14163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18003499#comment-18003499
]
ASF subversion and git services commented on IMPALA-14163:
----------------------------------------------------------
Commit 013bcc127f8c40b5d913642beea3ee1893930684 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=013bcc127 ]
IMPALA-14163: (Addendum) Always reset max-query-mem-limit
test_pool_config_change_while_queued now consistently pass in
TestAdmissionController and fail in
TestAdmissionControllerWithACService. The root cause of this issue is
because copy-mem-limit-test-llama-site.xml is only copied once for both
tests. TestAdmissionController left max-query-mem-limit of
invalidTestPool at 25MB without resetting it back to 0, which then cause
test failure at TestAdmissionControllerWithACService.
This patch improve the test by always setting max-query-mem-limit of
invalidTestPool at 0 both in the beginning and the end of test. Change
ResourcePoolConfig to use mem_limit_coordinators and mem_limit_executors
because, unlike mem_limit option, they are not subject to pool-level
memory clamping. Disable --clamp_query_mem_limit_backend_mem_limit flag
so that coord_backend_mem_limit is not clamped to coordinator's process
limit.
Removed make_copy parameter in test_pool_mem_limit_configs since it does
not mutate the config files.
Added more log details in admission-controller.cc to help make better
association.
Testing:
- Loop and pass the test in ARM build.
Change-Id: I41f671b8fb3eabf263041a834b54740fbacda68e
Reviewed-on: http://gerrit.cloudera.org:8080/23106
Reviewed-by: Yida Wu <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TestAdmissionControllerWithACService.test_pool_config_change_while_queued
> timing out
> ------------------------------------------------------------------------------------
>
> Key: IMPALA-14163
> URL: https://issues.apache.org/jira/browse/IMPALA-14163
> Project: IMPALA
> Issue Type: Bug
> Components: Test
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Assignee: Riza Suminto
> Priority: Critical
>
> TestAdmissionControllerWithACService.test_pool_config_change_while_queued
> still sometimes hits a timeout like this:
> {noformat}
> custom_cluster/test_admission_controller.py:1492: in
> test_pool_config_change_while_queued
> config.set_config_value(pool_name, config_str, 0)
> common/resource_pool_config.py:54: in set_config_value
> self.__wait_for_impala_to_pickup_config_change(pool_name, config_str,
> str(target_val))
> common/resource_pool_config.py:81: in
> __wait_for_impala_to_pickup_config_change
> metric_key, target_val, current_val)
> E AssertionError: Timed out waiting for
> admission-controller.pool-max-query-mem-limit.root.invalidTestPool to reach
> 0. Current: 1{noformat}
> This test was deflaked by IMPALA-14098, but this is happening after that fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
