[
https://issues.apache.org/jira/browse/IMPALA-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985042#comment-17985042
]
ASF subversion and git services commented on IMPALA-14142:
----------------------------------------------------------
Commit 1a381b6aea2d19d738119bd0e1c457e13a0d2763 in impala's branch
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1a381b6ae ]
IMPALA-14142: Fix TestIcebergV2Table.test_compute_stats_table_sampling
TestIcebergV2Table.test_compute_stats_table_sampling was failing in
ARM release builds. However, COMPUTE STATS with TABLESAMPLE is
inherently non-deterministic due to its use of SAMPLED_NDV().
This patch completely rewrites the tests and moves them to
test_stats_extrapolation.py to test Iceberg tables similarly to
legacy tables.
'diff_perc' argument of appx_equals() method was also updated in
the tests, as with the previous value (1.0) it only reported errors
for negative estimates.
Change-Id: I98b07b156aad300827c9e1b7970b8dfacfc6d251
Reviewed-on: http://gerrit.cloudera.org:8080/23044
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TestIcebergV2Table.test_compute_stats_table_sampling fails in exhaustive
> builds
> -------------------------------------------------------------------------------
>
> Key: IMPALA-14142
> URL: https://issues.apache.org/jira/browse/IMPALA-14142
> Project: IMPALA
> Issue Type: Bug
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
> Labels: broken-build, impala-iceberg
>
> h3. Error Message
> {noformat}
> assert Comparing QueryTestResults (expected vs actual):
> 'action','STRING',2,0,5,4.333333492279053,-1,-1 !=
> 'action','STRING',12,0,5,4.333333492279053,-1,-1
> 'event_time','TIMESTAMP',2,0,16,16,-1,-1 !=
> 'event_time','TIMESTAMP',12,0,16,16,-1,-1 'id','INT',3,0,4,4,-1,-1 !=
> 'id','INT',18,0,4,4,-1,-1 'user','STRING',2,0,4,4,-1,-1 !=
> 'user','STRING',12,0,4,4,-1,-1{noformat}
> h3. Stacktrace
> {noformat}
> query_test/test_iceberg.py:1554: in test_compute_stats_table_sampling
> self.run_test_case('QueryTest/iceberg-v2-compute-stats-table-sampling',
> vector)
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/common/impala_test_suite.py:915:
> in run_test_case
> self.__verify_results_and_errors(vector, test_section, result, use_db)
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/common/impala_test_suite.py:747:
> in __verify_results_and_errors
> replace_filenames_with_placeholder)
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/common/test_result_verifier.py:523:
> in verify_raw_results
> VERIFIER_MAP[verifier](expected, actual)
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/common/test_result_verifier.py:305:
> in verify_query_result_is_equal
> assert expected_results == actual_results
> E assert Comparing QueryTestResults (expected vs actual):
> E 'action','STRING',2,0,5,4.333333492279053,-1,-1 !=
> 'action','STRING',12,0,5,4.333333492279053,-1,-1
> E 'event_time','TIMESTAMP',2,0,16,16,-1,-1 !=
> 'event_time','TIMESTAMP',12,0,16,16,-1,-1
> E 'id','INT',3,0,4,4,-1,-1 != 'id','INT',18,0,4,4,-1,-1
> E 'user','STRING',2,0,4,4,-1,-1 !=
> 'user','STRING',12,0,4,4,-1,-1{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
