[
https://issues.apache.org/jira/browse/IMPALA-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954397#comment-17954397
]
ASF subversion and git services commented on IMPALA-13916:
----------------------------------------------------------
Commit 4d9612f514183c239ea43d179b569eb6649d30fa in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4d9612f51 ]
IMPALA-14097: Fix test_log_fragments.py
test_log_fragments.py broken after HS2 switch in IMPALA-13916. The test
look for log line from ImpalaServer::QueryToTQueryContext in
impala-beeswax-server.cc.
VLOG_QUERY << "query: " << ThriftDebugString(query);
This log line does not appear when using HS2 protocol. The equivalent
log line in impala-hs2-server.cc is in ImpalaServer::ExecuteStatement
VLOG_QUERY << "ExecuteStatement(): request=" << ...
This patch also remove redundant TExecuteStatementReq logging in
ImpalaServer::TExecuteStatementReqToTQueryContext. Either of
ImpalaServer::ExecuteStatement or ImpalaServer::ExecutePlannedStatement
has log the same TExecuteStatementReq already.
Testing:
- Run and pass test_log_fragments.py by itself.
Change-Id: I93e1fb6c7ba50f47023ca0c382a884093187b847
Reviewed-on: http://gerrit.cloudera.org:8080/22947
Reviewed-by: Quanlong Huang <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Switch BaseTestSuite.default_test_protocol to return HS2
> --------------------------------------------------------
>
> Key: IMPALA-13916
> URL: https://issues.apache.org/jira/browse/IMPALA-13916
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure, Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> Today, ImpalaTestSuite.client is equal to ImpalaTestSuite.beeswax_client by
> default.
> [https://github.com/apache/impala/blob/4617c2370faad08b44f4cffad1eda229d78696ee/tests/common/impala_test_suite.py#L424]
> We should change it so that it points to ImpalaTestSuite.hs2_client by
> switching BaseTestSuite.default_test_protocol() to return HS2.
> DEFAULT_TEST_PROTOCOL should also change to HS2.
> [https://github.com/apache/impala/blob/4617c2370faad08b44f4cffad1eda229d78696ee/tests/conftest.py#L59]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
