[
https://issues.apache.org/jira/browse/IMPALA-13389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953192#comment-17953192
]
ASF subversion and git services commented on IMPALA-13389:
----------------------------------------------------------
Commit 665601606937dee68517f3dba88d9f543b0d9f2d in impala's branch
refs/heads/master from Surya Hebbar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=665601606 ]
IMPALA-14032: Fix broken query timeline after webUI refactor in IMPALA-13389
Updated the identifiers in the following query timeline script according
to the new declrations.
Change-Id: I49a3e5405588edd07836605bff2efc00b9fa3ee9
Reviewed-on: http://gerrit.cloudera.org:8080/22857
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Riza Suminto <[email protected]>
Reviewed-by: Joe McDonnell <[email protected]>
> Refactor all webUI variable and function declarations to use ES6 syntax
> -----------------------------------------------------------------------
>
> Key: IMPALA-13389
> URL: https://issues.apache.org/jira/browse/IMPALA-13389
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Surya Hebbar
> Assignee: Surya Hebbar
> Priority: Major
>
> Using ES6 syntax with 'let' and 'const' greatly improves scoping,
> immutability, readability and helps in easier maintenance.
> In addition, it also improves the memory usage by reducing the scope.
> Also using ES6's arrow functions instead of traditional unnamed function
> declarations would be more cleaner and concise, where 'this' object within
> the function definition is bound to the surrounding context.
> It would be helpful if the variable and function names are revised to follow
> a single naming scheme, because in many instances across the scripts, no
> particular naming scheme has been followed.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
