[
https://issues.apache.org/jira/browse/IMPALA-11396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953025#comment-17953025
]
Riza Suminto commented on IMPALA-11396:
---------------------------------------
The test calls low_memory_limit_test with test_mem_limit equals 100 and 120 in
the test vector, and limit equals 120.
{code:python}
class TestLowMemoryLimits(ImpalaTestSuite):
'''Super class for the memory limit tests with the TPC-H and TPC-DS queries'''
def low_memory_limit_test(self, vector, tpch_query, limit):
# 'test_mem_limit' dimension is defined by subclasses of
TestLowMemoryLimits.
mem = vector.get_value('test_mem_limit')
# Mem consumption can be +-30MBs, depending on how many scanner threads are
# running. Adding this extra mem in order to reduce false negatives in the
tests.
limit = limit + 30
# If memory limit larger than the minimum threshold, then it is not
expected to fail.
expects_error = mem < limit
new_vector = copy(vector)
exec_options = new_vector.get_value('exec_option')
exec_options['mem_limit'] = str(mem) + "m"
# Reduce the page size to better exercise page boundary logic.
exec_options['default_spillable_buffer_size'] = "256k"
try:
self.run_test_case(tpch_query, new_vector)
except IMPALA_CONNECTION_EXCEPTION as e:
if not expects_error: raise
found_expected_error = False
for error_msg in MEM_LIMIT_ERROR_MSGS:
if error_msg in str(e): found_expected_error = True
assert found_expected_error, str(e)
{code}
Thus, it expect_error is True for this test vector.
However, the thrown error, "Couldn't skip rows in column" is not in
MEM_LIMIT_ERROR_MSGS list.
{code:python}
# Substrings of the expected error messages when the mem limit is too low
MEM_LIMIT_EXCEEDED_MSG = "Memory limit exceeded"
MEM_LIMIT_TOO_LOW_FOR_RESERVATION = ("minimum memory reservation is greater
than memory "
"available to the query for buffer reservations")
MEM_LIMIT_ERROR_MSGS = [MEM_LIMIT_EXCEEDED_MSG,
MEM_LIMIT_TOO_LOW_FOR_RESERVATION]
{code}
> test_low_mem_limit_orderby_all failed with Couldn't skip rows in column
> 'l_comment'
> -----------------------------------------------------------------------------------
>
> Key: IMPALA-11396
> URL: https://issues.apache.org/jira/browse/IMPALA-11396
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
> Labels: broken-build
>
> h1. Error Message
> {noformat}
> query_test/test_mem_usage_scaling.py:285: in test_low_mem_limit_orderby_all
> self.run_primitive_query(vector, 'primitive_orderby_all')
> query_test/test_mem_usage_scaling.py:273: in run_primitive_query
> self.low_memory_limit_test(vector, query_name, self.MIN_MEM[query_name])
> query_test/test_mem_usage_scaling.py:123: in low_memory_limit_test assert
> found_expected_error, str(e) E AssertionError: ImpalaBeeswaxException: E
> Query aborted:Couldn't skip rows in column 'l_comment' in file
> 'hdfs://localhost:20500/test-warehouse/tpch.lineitem_parquet/f945f1c7c70575f9-1248a6b300000002_1158168046_data.0.parq'.
> E E E assert False
> {noformat}
> h1. Stacktrace
> {noformat}
> query_test/test_mem_usage_scaling.py:285: in test_low_mem_limit_orderby_all
> self.run_primitive_query(vector, 'primitive_orderby_all')
> query_test/test_mem_usage_scaling.py:273: in run_primitive_query
> self.low_memory_limit_test(vector, query_name, self.MIN_MEM[query_name])
> query_test/test_mem_usage_scaling.py:123: in low_memory_limit_test
> assert found_expected_error, str(e)
> E AssertionError: ImpalaBeeswaxException:
> E Query aborted:Couldn't skip rows in column 'l_comment' in file
> 'hdfs://localhost:20500/test-warehouse/tpch.lineitem_parquet/f945f1c7c70575f9-1248a6b300000002_1158168046_data.0.parq'.
> E
> E
> E assert False
> {noformat}
> h1. Standard Error
> {noformat}
> SET
> client_identifier=query_test/test_mem_usage_scaling.py::TestTpchPrimitivesMemLimitError::()::test_low_mem_limit_orderby_all[mem_limit:120|protocol:beeswax|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disable_codegen':False;';
> -- executing against localhost:21000
> use tpch_parquet;
> -- 2022-06-26 19:11:11,832 INFO MainThread: Started query
> a24ee409167fc20e:11fb7f1a00000000
> SET
> client_identifier=query_test/test_mem_usage_scaling.py::TestTpchPrimitivesMemLimitError::()::test_low_mem_limit_orderby_all[mem_limit:120|protocol:beeswax|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disable_codegen':False;';
> SET test_replan=1;
> SET batch_size=0;
> SET num_nodes=0;
> SET disable_codegen_rows_threshold=0;
> SET disable_codegen=False;
> SET abort_on_error=1;
> SET default_spillable_buffer_size=256k;
> SET mem_limit=120m;
> SET exec_single_node_rows_threshold=0;
> -- 2022-06-26 19:11:11,833 INFO MainThread: Loading query test file:
> /data/jenkins/workspace/impala-cdw-master-staging-exhaustive/repos/Impala/testdata/workloads/targeted-perf/queries/primitive_orderby_all.test
> -- 2022-06-26 19:11:13,848 INFO MainThread: Query Name:
> primitive_orderby_all
> -- executing against localhost:21000
> -- Description : Scan a fact table and sort 50Million rows.
> -- Target test case : Order by all columns in the table without returning all
> -- rows to the client.
> SELECT *
> FROM (
> SELECT Rank() OVER (
> ORDER BY l_extendedprice
> ,l_orderkey
> ,l_partkey
> ,l_suppkey
> ,l_linenumber
> ,l_quantity
> ,l_discount
> ,l_tax
> ,l_returnflag
> ,l_linestatus
> ,l_shipdate
> ,l_commitdate
> ,l_receiptdate
> ,l_shipinstruct
> ,l_shipmode
> ,l_comment
> ) AS rank
> FROM lineitem
> WHERE l_shipdate < '1992-05-09'
> ) a
> WHERE rank < 10 or rank > 99999999999;
> -- 2022-06-26 19:11:13,857 INFO MainThread: Started query
> a942221768a7861f:9bf0d77200000000
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
