[
https://issues.apache.org/jira/browse/IMPALA-14072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951692#comment-17951692
]
ASF subversion and git services commented on IMPALA-14072:
----------------------------------------------------------
Commit 6831076983bedc0a8ba9ff199709ff93e6af2702 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=683107698 ]
IMPALA-14072: Fix NPE in Catalogd during rename.
test_rename_drop fail with NPE after IMPALA-14042. This is because
CatalogServiceCatalog.renameTable() return null for not finding the
database of oldTableName. This patch change renameTable() to return
Pair.create(null, null) for that scenario.
Refactor test_rename_drop slightly to ensure that invalidating the
renamed table and dropping it are successful.
Testing:
- Add checkNotNull precondition in
CatalogOpExecutor.alterTableOrViewRename()
- Increase catalogd_table_rename_delay delay to 6s to ensure that DROP
query happen in Catalogd before renameTable() called. Manually
observed that No NPE is shown anymore.
Change-Id: I7a421a71cf3703290645e85180de8e9d5e86368a
Reviewed-on: http://gerrit.cloudera.org:8080/22899
Reviewed-by: Quanlong Huang <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Fix TestConcurrentRename.test_rename_drop
> -----------------------------------------
>
> Key: IMPALA-14072
> URL: https://issues.apache.org/jira/browse/IMPALA-14072
> Project: IMPALA
> Issue Type: Bug
> Reporter: Noémi Pap-Takács
> Assignee: Riza Suminto
> Priority: Major
> Labels: broken-build
>
> Stacktrace
> {code:java}
> custom_cluster/test_concurrent_rename.py:56: in test_rename_drop
> assert "The new table/view {}2 was concurrently removed during rename."\
> E assert 'The new table/view test_rename_drop_aaefe83a.tbl2 was
> concurrently removed during rename.' in 'Expected alter to fail\nassert False'
> E + where 'The new table/view test_rename_drop_aaefe83a.tbl2 was
> concurrently removed during rename.' = <built-in method format of str object
> at 0x7fa0d2e583d8>('test_rename_drop_aaefe83a.tbl')
> E + where <built-in method format of str object at 0x7fa0d2e583d8> =
> 'The new table/view {}2 was concurrently removed during rename.'.format
> E + and 'Expected alter to fail\nassert False' =
> str(AssertionError(u'Expected alter to fail\nassert False',)) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
