[
https://issues.apache.org/jira/browse/IMPALA-14028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951542#comment-17951542
]
ASF subversion and git services commented on IMPALA-14028:
----------------------------------------------------------
Commit f18cfaf0db4c5141d6fc05f7b3feb687ea7eaf8b in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f18cfaf0d ]
IMPALA-14028: Refactor cancel_query_and_validate_state with HS2
cancel_query_and_validate_state is a helper method used to test query
cancellation with concurrent fetch. It is still use beeswax client by
default.
This patch change the test method to use HS2 protocol by default. The
changes include following:
1. Set TGetOperationStatusResp.operationState to
TOperationState::ERROR_STATE if returning abnormally.
2. Use separate MinimalHS2Client for
(execute_async, fetch, get_runtime_profile) vs cancel vs close.
Cancellation through KILL QUERY still instantiate new
ImpylaHS2Connection client.
3. Implement required missing methods in MinimalHS2Client.
4. Change MinimalHS2Client logging pattern to match with other clients.
Testing:
Pass test_cancellation.py and TestResultSpoolingCancellation in core
exploration mode. Also fix default_test_protocol to HS2 for these tests.
Change-Id: I626a1a06eb3d5dc9737c7d4289720e1f52d2a984
Reviewed-on: http://gerrit.cloudera.org:8080/22853
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Riza Suminto <[email protected]>
> Modify cancel_query_and_validate_state to work with Impyla
> ----------------------------------------------------------
>
> Key: IMPALA-14028
> URL: https://issues.apache.org/jira/browse/IMPALA-14028
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure, Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> cancel_query_and_validate_state is a helper method used to test query
> cancellation with concurrent fetch. It is still use beeswax client by default.
> Ideally, we should change this test to use HS2 protocol by default. But
> ImpylaHS2Connection, a wrapper of Impyla, is not thread safe. We need to
> relax this test method in several way:
> # Implement HS2_OPERATION_RETURN_IF_ERROR. Similar like
> HS2_RETURN_IF_ERROR, but additionally set operationState to
> TOperationState::ERROR_STATE.
> # Make client operation such as execute_async, fetch, cancel,
> get_runtime_profile mutually exclusive.
> # Do not attempt to fetch if there is a debug action set to prevent it (ie.,
> wait GetNext indefinitely).
> # Do not attempt to fetch if query handle is error right after execute_async.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
