[
https://issues.apache.org/jira/browse/IMPALA-14039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950477#comment-17950477
]
ASF subversion and git services commented on IMPALA-14039:
----------------------------------------------------------
Commit f2acd2381ffb3d33f5789bc6086b7d821bad4561 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f2acd2381 ]
IMPALA-14039: __restore_query_options should unset query option
ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.
Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.
ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:
SET query_option="";
This patch also change execute_query_using_vector() to simply unset
client's configuration.
Follow up cleanup will be tracked through IMPALA-14060.
Testing:
Run and pass test_queries.py::TestQueries.
Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Reviewed-on: http://gerrit.cloudera.org:8080/22862
Reviewed-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> __restore_query_options should simply unset query option
> --------------------------------------------------------
>
> Key: IMPALA-14039
> URL: https://issues.apache.org/jira/browse/IMPALA-14039
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure, Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> ImpalaTestSuite.__restore_query_options() attempt to restore client's
> configuration with what it understand as the "default" query option.
> [https://github.com/apache/impala/blob/cb496104d98e8cbd87acf25277f2648cffaac42a/tests/common/impala_test_suite.py#L546-L570]
> Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse the
> default query option from TQueryOption fields. Therefore, it might not
> respect server's default that comes from --default_query_options flag.
> ImpalaTestSuite.__restore_query_options() should simply unset any
> configuration that previously set by running query:
> {code:java}
> SET query_option="";
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
