[
https://issues.apache.org/jira/browse/IMPALA-14027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949828#comment-17949828
]
ASF subversion and git services commented on IMPALA-14027:
----------------------------------------------------------
Commit cb496104d98e8cbd87acf25277f2648cffaac42a in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=cb496104d ]
IMPALA-14027: Implement HS2 NULL_TYPE using TStringValue
HS2 NULL_TYPE should be implemented using TStringValue.
However, due to incompatibility with Hive JDBC driver implementation
then, Impala choose to implement NULL type using TBoolValue (see
IMPALA-914, IMPALA-1370).
HIVE-4172 might be the root cause for such decision. Today, the Hive
JDBC (org.apache.hive.jdbc.HiveDriver) does not have that issue anymore,
as shown in this reproduction after applying this patch:
./bin/run-jdbc-client.sh -q "select null" -t NOSASL
Using JDBC Driver Name: org.apache.hive.jdbc.HiveDriver
Connecting to: jdbc:hive2://localhost:21050/;auth=noSasl
Executing: select null
----[START]----
NULL
----[END]----
Returned 1 row(s) in 0.343s
Thus, we can reimplement NULL_TYPE using TStringValue to match
HiveServer2 behavior.
Testing:
- Pass core tests.
Change-Id: I354110164b360013d9893f1eb4398c3418f80472
Reviewed-on: http://gerrit.cloudera.org:8080/22852
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Reimplement HS2 NULL_TYPE using TStringValue
> --------------------------------------------
>
> Key: IMPALA-14027
> URL: https://issues.apache.org/jira/browse/IMPALA-14027
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> HS2 NULL_TYPE should be implemented using TStringValue.
> [https://github.com/apache/impala/blob/55804f78740bf5e05aaee2634dec249fefb431a0/common/thrift/hive-1-api/TCLIService.thrift#L327]
>
> However, due to incompatibility with Hive JDBC driver implementation then,
> Impala choose to implement NULL type using TBoolValue (see IMPALA-914,
> IMPALA-1370).
> The Hive JDBC issue is not there anymore. Thus, we can reimplement NULL_TYPE
> using TStringValue to match HiveServer2 behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
