[
https://issues.apache.org/jira/browse/IMPALA-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948951#comment-17948951
]
ASF subversion and git services commented on IMPALA-13978:
----------------------------------------------------------
Commit 47913c10e8f49d0eb9a532108cd55ea6dbc69ee3 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=47913c10e ]
IMPALA-13978: Remove gutil's gscoped_ptr/bind/callback functionality
gutil's gscoped_ptr/bind/callback provide functionality that
was introduced in C++11. It has been obsolete for a long time
and is barely used in the codebase. Kudu removed this code from
their gutils quite a while ago:
https://github.com/apache/kudu/commit/4f7b1aaf88
This replaces gscoped_ptr/gscoped_array with std::unique_ptr
(matching Kudu's modifications for gutil). This removes gutil's
bind/callback/move, as they are now unused.
Testing:
- Ran precommit
Change-Id: I2ec79f32fb281f2bceeaed3e2fcbc75ae75308bd
Reviewed-on: http://gerrit.cloudera.org:8080/22821
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
> Remove gutil's gscoped_ptr/bind/callback functionality
> ------------------------------------------------------
>
> Key: IMPALA-13978
> URL: https://issues.apache.org/jira/browse/IMPALA-13978
> Project: IMPALA
> Issue Type: Task
> Components: Backend
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Priority: Major
>
> The functionality in the gutil/gscoped_ptr.h header is obsolete with the
> modern C++ standard library. Kudu removed this a while back in
> [https://github.com/apache/kudu/commit/4f7b1aaf88d848b45083ab62d50c1c457c943954]
> We should bring those modifications over and adjust any other locations in
> our code. gscoped_ptr/gscoped_array can be replaced with std::unique_ptr.
> gutil/bind* and gutil/callback* headers are also unused. Once
> gutil/gscoped_ptr.h is gone, gutil/move.h can be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
