[
https://issues.apache.org/jira/browse/IMPALA-13929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941791#comment-17941791
]
ASF subversion and git services commented on IMPALA-13929:
----------------------------------------------------------
Commit f98b697c7b37e18cb1101b62243974e42f72b9f4 in impala's branch
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f98b697c7 ]
IMPALA-13929: Make 'functional-query' the default workload in tests
This change adds get_workload() to ImpalaTestSuite and removes it
from all test suites that already returned 'functional-query'.
get_workload() is also removed from CustomClusterTestSuite which
used to return 'tpch'.
All other changes besides impala_test_suite.py and
custom_cluster_test_suite.py are just mass removals of
get_workload() functions.
The behavior is only changed in custom cluster tests that didn't
override get_workload(). By returning 'functional-query' instead
of 'tpch', exploration_strategy() will no longer return 'core' in
'exhaustive' test runs. See IMPALA-3947 on why workload affected
exploration_strategy. An example for affected test is
TestCatalogHMSFailures which was skipped both in core and exhaustive
runs before this change.
get_workload() functions that return a different workload than
'functional-query' are not changed - it is possible that some of
these also don't handle exploration_strategy() as expected, but
individually checking these tests is out of scope in this patch.
Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115
Reviewed-on: http://gerrit.cloudera.org:8080/22726
Reviewed-by: Riza Suminto <[email protected]>
Reviewed-by: Daniel Becker <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Make 'functional-query' the default workload in ImpalaTestSuite
> ---------------------------------------------------------------
>
> Key: IMPALA-13929
> URL: https://issues.apache.org/jira/browse/IMPALA-13929
> Project: IMPALA
> Issue Type: Test
> Components: Test
> Reporter: Csaba Ringhofer
> Assignee: Csaba Ringhofer
> Priority: Major
>
> The usage of get_workload() in tests is not intuitive and generally useless -
> most test suites return 'functional-query' and ones that don't can have
> unexpected behavior regarding 'core' vs 'exhaustive' exploration_strategy
> (see IMPALA-3947 for detailed description).
> Returning 'functional-query' by default and overriding get_workload() only
> in suites that return a different workload would allow removing a lot of
> boilerplate code avoid potential mistakes related to exploration_strategy. An
> example is TestCatalogHMSFailures, which is currently skipped even in
> exhaustive test runs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
