[ 
https://issues.apache.org/jira/browse/IMPALA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939359#comment-17939359
 ] 

ASF subversion and git services commented on IMPALA-13859:
----------------------------------------------------------

Commit 76a8efb155d2ea3a9a1d36f2bd5428fd5ffa1d2d in impala's branch 
refs/heads/master from Daniel Vanko
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=76a8efb15 ]

IMPALA-13859: Add decimal to Kudu's supported primary key types

Add DECIMAL to KuduUtil.isSupportedKeyType because it is a supported
type for primary key by Kudu.

Testing:
 * add fe tests
 * add e2e tests

Change-Id: I0e8685fe89e4e4e511ab1d815c51ca5a021b4081
Reviewed-on: http://gerrit.cloudera.org:8080/22674
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Zoltan Borok-Nagy <[email protected]>


> Add decimal to Kudu's supported primary key types
> -------------------------------------------------
>
>                 Key: IMPALA-13859
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13859
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>            Reporter: Dániel Gábor Vankó
>            Assignee: Dániel Gábor Vankó
>            Priority: Major
>              Labels: kudu
>
> Currently in our KuduUtil class [isSupportedKeyType(type) 
> function|https://github.com/apache/impala/blob/8093c3fa6b44f7f6ec699d2dd47581401f75f363/fe/src/main/java/org/apache/impala/util/KuduUtil.java#L392-L395]
>  returns false if its argument is decimal type. However, Apache Kudu only 
> restricts double, float and bool columns to be primary keys:
> [https://kudu.apache.org/releases/1.17.0/docs/known_issues.html#_primary_keys]
> {quote}Columns with {{{}DOUBLE{}}}, {{{}FLOAT{}}}, or {{BOOL}} types are not 
> allowed as part of a primary key definition.
> {quote}
> ([actually that's the case even in Kudu 
> 1.0.0|https://kudu.apache.org/releases/1.0.0/docs/release_notes.html#_schema_and_usage_limitations])



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to