[ 
https://issues.apache.org/jira/browse/IMPALA-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937071#comment-17937071
 ] 

ASF subversion and git services commented on IMPALA-13877:
----------------------------------------------------------

Commit 4d846f0d4bf61f8b44f36c6e59b1ae9251b7bdcd in impala's branch 
refs/heads/master from Mihaly Szjatinya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4d846f0d4 ]

IMPALA-13877: Fix missing stats time in TestLastDdlTimeUpdate

This patch fixes broken tests after IMPALA-11597 that only show up in
exhaustive exploration.

Expanded TestHelper to able to check set/unset operations, in addition
to changed/unchaged. Updated tests accordingly.

Change-Id: I99e37b9168c2c79a913ca0c717cad1ed9253100a
Reviewed-on: http://gerrit.cloudera.org:8080/22643
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Tests in TestLastDdlTimeUpdate fail with missing 'impala.lastComputeStatsTime'
> ------------------------------------------------------------------------------
>
>                 Key: IMPALA-13877
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13877
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>            Reporter: Daniel Becker
>            Assignee: Mihaly Szjatinya
>            Priority: Blocker
>              Labels: broken-build
>
> Tests
> {code:java}
> metadata.test_last_ddl_time_update.TestLastDdlTimeUpdate.test_alter{code}
> {code:java}
> metadata.test_last_ddl_time_update.TestLastDdlTimeUpdate.test_kudu_alter_and_insert{code}
> fail in some builds because they call {{expect_no_time_change()}} on a {{DROP 
> STATS}} statement. SinceĀ IMPALA-11597, {{DRO}}{{{}P STATS{}}} deletes the 
> 'impala.lastComputeStatsTime' table property. The test assertions should be 
> updated to reflect the new behaviour.
> Error Message
> {code:java}
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:223:
>  in test_kudu_alter_and_insert     self.run_common_test_cases(h) 
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:260:
>  in run_common_test_cases     h.expect_no_time_change("drop stats %(TBL)s") 
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:61:
>  in expect_no_time_change     self.run_test(query, False, False) 
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:110:
>  in run_test     self.db_name, self.tbl_name) 
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:142:
>  in _get_ddl_and_stats_time     statsTime = 
> table.parameters[LAST_COMPUTE_STATS_TIME_KEY] E   KeyError: 
> 'impala.lastComputeStatsTime'
> {code}
> Stacktrace
> {code:java}
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:223:
>  in test_kudu_alter_and_insert
>     self.run_common_test_cases(h)
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:260:
>  in run_common_test_cases
>     h.expect_no_time_change("drop stats %(TBL)s")
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:61:
>  in expect_no_time_change
>     self.run_test(query, False, False)
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:110:
>  in run_test
>     self.db_name, self.tbl_name)
> /data/jenkins/workspace/impala-asf-master-exhaustive-release-arm/repos/Impala/tests/metadata/test_last_ddl_time_update.py:142:
>  in _get_ddl_and_stats_time
>     statsTime = table.parameters[LAST_COMPUTE_STATS_TIME_KEY]
> E   KeyError: 'impala.lastComputeStatsTime'
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to