[
https://issues.apache.org/jira/browse/IMPALA-13843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Surya Hebbar updated IMPALA-13843:
----------------------------------
Description:
The RapidJSON library recalculates length of a StringRef each time when using
char*, until null character.
Within the codebase, many times we are converting from string->char* for
RapidJSON.
Instead with RAPIDJSON_HAS_STDSTRING, we can use strings directly, which
contain the size, instead of recalculating or size declaration each time.
This is efficient and a major convenience for DOM creation.
This impacts large JSON profiles, where this is repeated multiple times.
was:
The RapidJSON library recalculates length of a StringRef each time when using
char*, until null character.
Within the codebase, many times we are converting from string->char* for
RapidJSON.
This impacts large JSON profiles where this is repeated multiple times.
This is redundant. Instead with RAPIDJSON_HAS_STDSTRING, we can use strings
directly, which contains the size, instead of recalculating each time.
> Use strings directly in rapidjson without conversion to char*
> -------------------------------------------------------------
>
> Key: IMPALA-13843
> URL: https://issues.apache.org/jira/browse/IMPALA-13843
> Project: IMPALA
> Issue Type: New Feature
> Reporter: Surya Hebbar
> Assignee: Surya Hebbar
> Priority: Major
>
> The RapidJSON library recalculates length of a StringRef each time when using
> char*, until null character.
> Within the codebase, many times we are converting from string->char* for
> RapidJSON.
> Instead with RAPIDJSON_HAS_STDSTRING, we can use strings directly, which
> contain the size, instead of recalculating or size declaration each time.
> This is efficient and a major convenience for DOM creation.
> This impacts large JSON profiles, where this is repeated multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
