[
https://issues.apache.org/jira/browse/IMPALA-13823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933179#comment-17933179
]
ASF subversion and git services commented on IMPALA-13823:
----------------------------------------------------------
Commit 7ae19b069e6f2108b34757b052467706d1adbe16 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7ae19b069 ]
IMPALA-13823: Clear existing entry of TMP_DIRS at cluster_setup
Assertion was hit at CustomClusterTestSuite.make_tmp_dir() for
attempting to create tmp dir that already have mapping in
CustomClusterTestSuite.TMP_DIRS. It can happen if different custom
cluster tests run declare the same tmp_dir_placeholders, and one of the
earlier run fail to teardown properly, resulting in clear_tmp_dirs() not
being called.
This patch fix the issue by clearing existing TMP_DIRS entry without
removing the underlying filesystem path. Along with it, a WARN log will
be printed, saying about dirty entry in TMP_DIRS.
Testing:
- Manually comment clear_tmp_dirs() call in cluster_teardown() and run
TestQueryLogTableBufferPool.test_select. Confirmed that all 4 of its
test runs complete, the warning logs printed to
logs/custom_cluster_tests/results/TEST-impala-custom-cluster.xml
and the tmp dir stays in logs/custom_cluster_tests/.
Change-Id: I3f528bb155eb3cf4dfa58a6a23feb438809556bc
Reviewed-on: http://gerrit.cloudera.org:8080/22572
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> assertion hit at CustomClusterTestSuite.make_tmp_dir
> ----------------------------------------------------
>
> Key: IMPALA-13823
> URL: https://issues.apache.org/jira/browse/IMPALA-13823
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure, Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Labels: broken-build
>
> Assertion hit at CustomClusterTestSuite.make_tmp_dir
> {noformat}
> common/custom_cluster_test_suite.py:242: in make_tmp_dir
> assert name not in cls.TMP_DIRS{noformat}
> This is because, when different custom cluster tests run declare
> tmp_dir_placeholders, and one of it fail, cluster_teardown did not happen,
> and tmp dir removal did not happen as well.
> We need to relax this assertion and print WARN log instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
