[ 
https://issues.apache.org/jira/browse/IMPALA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932056#comment-17932056
 ] 

ASF subversion and git services commented on IMPALA-13716:
----------------------------------------------------------

Commit e427ad3c3f5a36aacf107e8535963aaf0725a924 in impala's branch 
refs/heads/master from Fang-Yu Rao
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e427ad3c3 ]

IMPALA-13716 (Addendum): Simplify the call site of createSingleNodePlan()

IMPALA-13716 added an input argument to createSingleNodePlan() that
requires the caller to provide a List of TupleIsNullPredicate. Since
this List depends only on the given PlanNode, this patch adds a
method that computes this List when it is not provided by the caller,
which simplifies the call site as well.

This patch also moves getTupleIsNullPreds() to AnalyticPlanner.java
because it is only used in AnalyticPlanner.java. We make the method
a static one because it's not specific to an instance of
AnalyticPlanner.java.

Change-Id: Ie10361f15db4c0eb2cf5ff5f4d0a28c612b1a930
Reviewed-on: http://gerrit.cloudera.org:8080/22564
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Riza Suminto <[email protected]>


> Calcite Planner: Queries with TupleIsNullPredicate failing for analytic 
> functions
> ---------------------------------------------------------------------------------
>
>                 Key: IMPALA-13716
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13716
>             Project: IMPALA
>          Issue Type: Sub-task
>            Reporter: Steve Carlin
>            Priority: Major
>
> There is some logic materializing the TupleIsNullPredicate (created for outer 
> joins) special for analytic functions that needs to be implemented for the 
> Calcite Planner.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to