[ 
https://issues.apache.org/jira/browse/IMPALA-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931321#comment-17931321
 ] 

ASF subversion and git services commented on IMPALA-13802:
----------------------------------------------------------

Commit a4f303ea55dbd299ee4153ca605851281269fe4c in impala's branch 
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a4f303ea5 ]

IMPALA-13802: move postgresql init to the end of bin/bootstrap_system.sh

postgresql initialization can fail if run a second time:
sudo service postgresql initdb
3 ERROR: Data directory /var/lib/pgsql/data is not empty!

This can led to skipping the rest of the script - a
quick fix is to deal with postgresql at the end.

Change-Id: I55e862ebe3b823e4aeaaa656d5536b6317b5e19c
Reviewed-on: http://gerrit.cloudera.org:8080/22550
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> bootstrap_system.sh can fail in the middle in dirty environment
> ---------------------------------------------------------------
>
>                 Key: IMPALA-13802
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13802
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>            Reporter: Csaba Ringhofer
>            Assignee: Csaba Ringhofer
>            Priority: Major
>
> This comes up regularly when building on reused RHEL8 build instances:
> {code}
> 00:00:28.224 + sudo service postgresql initdb
> 00:00:28.241 Hint: the preferred way to do this is now 
> "/usr/bin/postgresql-setup --initdb --unit postgresql"
> 00:00:28.302  * Initializing database in '/var/lib/pgsql/data'
> 00:00:28.303 ERROR: Data directory /var/lib/pgsql/data is not empty!
> 00:00:28.303 ERROR: Initializing database failed, possibly see 
> /var/lib/pgsql/initdb_postgresql.log
> {code}
> this leads to prematurely exiting the script at: 
> https://github.com/apache/impala/blob/ce9b927d547ac4290275fede4843288bbf97a429/bin/bootstrap_system.sh#L399
> surprisingly this doesn't seem to cause subsequent issues - probably it is 
> enough that the rest of script already ran once
> If already touching this area, it would be nice to move logic related to 
> IMPALA_HOME to another script, as it is not needed in automatic tests and can 
> be a nuisance in personal builds as it messes with .bashrc
> https://github.com/apache/impala/blob/ce9b927d547ac4290275fede4843288bbf97a429/bin/bootstrap_system.sh#L518



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to