[
https://issues.apache.org/jira/browse/IMPALA-13785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931323#comment-17931323
]
ASF subversion and git services commented on IMPALA-13785:
----------------------------------------------------------
Commit 91343369f7f34c0990129d565b9172001ee5570b in impala's branch
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=91343369f ]
IMPALA-13785: Deflake test_catalog_tables_stats in exhaustive build
IMPALA-13737 changed how we load file metadata for Iceberg tables,
as we don't rely on the underlying HdfsTable anymore. As a result,
metrics were not correctly updated. This patch adds code to update
metrics correctly.
Testing:
* executed the tests in the title in exhaustive mode
* added Iceberg-specific tests to test_web_pages
Change-Id: I686e0e32b36ace4c5a8c9eeb715148c98521252a
Reviewed-on: http://gerrit.cloudera.org:8080/22531
Reviewed-by: Quanlong Huang <[email protected]>
Reviewed-by: Noemi Pap-Takacs <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Riza Suminto <[email protected]>
> test_catalog_tables_stats_legacy_catalog and
> test_catalog_tables_stats_local_catalog seem to be flaky in the exhaustive
> build
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: IMPALA-13785
> URL: https://issues.apache.org/jira/browse/IMPALA-13785
> Project: IMPALA
> Issue Type: Bug
> Reporter: Fang-Yu Rao
> Assignee: Xuebin Su
> Priority: Major
> Labels: broken-build
>
> We found that *test_catalog_tables_stats_legacy_catalog()* and
> *test_catalog_tables_stats_local_catalog()* seem to be flaky in the
> exhaustive build.
>
> The following are the error and stacktrace of
> {*}test_catalog_tables_stats_legacy_catalog(){*}.
>
> +*Error Message*+
> {code:java}
> assert 0 == 4 + where 0 = <function get_table_metric at
> 0x7ff9287a80c8>({'__common__': {'navbar': [{'link': '/', 'title': '/'},
> {'link': '/catalog', 'title': '/catalog'}, {'link': '/events',...as_metrics':
> True, 'name': 'alltypesaggnonulls'}, ...]}, ...], 'frequent_tables': [],
> 'has_frequent_tables': True, ...}, 'high_file_count_tables', 'num_files')
> {code}
> +*Stacktrace*+
> {code:java}
> custom_cluster/test_web_pages.py:539: in
> test_catalog_tables_stats_legacy_catalog
> "functional_parquet.iceberg_lineitem_sixblocks", 4)
> custom_cluster/test_web_pages.py:530: in
> _test_catalog_tables_stats_after_describe
> assert get_table_metric(content, "high_file_count_tables", "num_files")
> == num_files
> E assert 0 == 4
> E + where 0 = <function get_table_metric at
> 0x7ff9287a80c8>({'__common__': {'navbar': [{'link': '/', 'title': '/'},
> {'link': '/catalog', 'title': '/catalog'}, {'link': '/events',...as_metrics':
> True, 'name': 'alltypesaggnonulls'}, ...]}, ...], 'frequent_tables': [],
> 'has_frequent_tables': True, ...}, 'high_file_count_tables', 'num_files')
> {code}
>
> The tables involved seem to be of the iceberg format. Not very sure if this
> issue has something to do with the following patches recently merged.
> # IMPALA-13201: System Table Queries Execute When Admission Queues are
> # IMPALA-13627: Handle legacy Hive timezone conversion
> # IMPALA-13761: Fix test_coord_only_pool_exec_groups
> # IMPALA-13752: Remove option value quoting in __restore_query_options
> # IMPALA-13737: Directly load file metadata via IcebergFileMetadataLoader
> # IMPALA-13759: Fix Hive ACID INSERT OVERWRITE base detection
> # IMPALA-13758: Use context manager in ImpalaTestSuite.change_database
> # IMPALA-13771: Fix heap-use-after-free in Cluster Membership Manager
> # IMPALA-13768: Redundant Iceberg delete records are shuffled around which
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
