[
https://issues.apache.org/jira/browse/IMPALA-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930629#comment-17930629
]
Csaba Ringhofer commented on IMPALA-13790:
------------------------------------------
Btw theses tests were added with Impala's TSSLSocketWithWildcardSAN which
overrides Thrift's TSSLSocket. TSSLSocketWithWildcardSAN may be no longer
necessary - at that time Impala was using 0.9.0 Thrift and SAN cert support in
Python seems to be added in Thrift 0.10.0.
It would be nice if TSSLSocketWithWildcardSAN as partially overriding
TSSLSocket looks error prone.
Impala change that added the tests:
https://github.com/apache/impala/commit/45ff0f9e674f54b35afb2b5eced0d6ec346890d6
Thrift SAN support:
https://github.com/apache/thrift/commit/25536ad83a85cfda6d5388278e4e378f2d4df73e
> Remove xfail from test_wildcard_san_ssl / test_wildcard_ssl
> -----------------------------------------------------------
>
> Key: IMPALA-13790
> URL: https://issues.apache.org/jira/browse/IMPALA-13790
> Project: IMPALA
> Issue Type: Bug
> Components: Clients, Infrastructure
> Reporter: Csaba Ringhofer
> Priority: Major
>
> These tests have a history:
> https://github.com/apache/impala/commit/45ff0f9e674f54b35afb2b5eced0d6ec346890d6
> https://github.com/apache/impala/commit/c163ac1468e4d878c3516ec933c69fb66851af01
> https://github.com/apache/impala/commit/d3cf6d325779fff4ab0ba9db53411c510aa0f717
> The xfails were added a long time ago and hide the real status of tests. My
> impression is that the tests xfail or xpass on every OS.
> They also take significant amount of time. From RHEL8 tests:
> {code}
> custom_cluster.test_client_ssl.TestClientSsl.test_wildcard_san_ssl[impala_shell:
> dev | protocol: hs2 | table_format: text/none | exec_option: {'test_replan':
> 1, 'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0,
> 'disable_codegen': False, 'abort_on_error': 1,
> 'exec_single_node_rows_threshold': 0}] (from pytest)
> Skip Message
> expected test failure
> Standard Error
> -- 2025-02-20 02:50:33,882 INFO MainThread: Starting cluster with
> command: /
> s/common/impala_cluster.py", line 245, in wait_until_ready
> impalad.wait_for_coordinator_services(sleep_interval,
> check_processes_still_running)
> s/common/impala_cluster.py", line 655, in wait_for_coordinator_services
> raise RuntimeError(
> RuntimeError: Unable to open client ports within 240 seconds.
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
