[
https://issues.apache.org/jira/browse/IMPALA-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907158#comment-17907158
]
ASF subversion and git services commented on IMPALA-13526:
----------------------------------------------------------
Commit 818057b8758f8b3d3b669f88698033c6f5b79f27 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=818057b87 ]
IMPALA-13526: Fix Agg node creation order in DistributedPlanner
Within DistributedPlanner.java, there are several places where Planner
need to insert extra merge aggregation node. It requires transferring
HAVING conjuncts from preaggregation node to merge aggregation,
unsetting limit, and recompute stats of preaggregation node. However,
the stats recompute is not consistently done, and there might be an
inefficient recompute happening.
This patch fixes the order of AggregationNode creation order in
DistributedPlanner.java so that stats recomputation is done consistently
and efficiently.
Testing:
- Pass core tests.
Change-Id: Ica8227fdc46a1ef59bef5ae5424ba3907827411d
Reviewed-on: http://gerrit.cloudera.org:8080/22046
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Riza Suminto <[email protected]>
> Inconsistent Agg node stats recomputation.
> ------------------------------------------
>
> Key: IMPALA-13526
> URL: https://issues.apache.org/jira/browse/IMPALA-13526
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Affects Versions: Impala 4.4.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 4.5.0
>
>
> Within DistributedPlanner.java, there are several place where Planner need to
> insert extra merge aggregation node. It require transferring HAVING conjuncts
> from preaggregation node to merge aggregation, unsetting limit, and recompute
> stats of preaggregation node. However, the stats recompute is not
> consistently done, and there might be an inefficient recompute happening.
> Example of inefficient recomputes:
> https://github.com/apache/impala/blob/88e0e4e8baa97f7fded12230b14232dc85cf6d79/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java#L1074-L1077
> Example of missing recompute for phase2AggNode:
> https://github.com/apache/impala/blob/88e0e4e8baa97f7fded12230b14232dc85cf6d79/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java#L1143-L1168
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
