[
https://issues.apache.org/jira/browse/IMPALA-13585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902309#comment-17902309
]
ASF subversion and git services commented on IMPALA-13585:
----------------------------------------------------------
Commit d3ae4a416e1bd6c0bf98fdcf635063d2ab7233a2 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d3ae4a416 ]
IMPALA-13585: Make pip_download.py interruptible
infra/python/deps/pip_download.py use multiprocessing.pool.ThreadPool
where each thread calls wget. It is also wrap the download_package
function with retry wrapper. When there is a network issue happen,
pressing Ctrl+C does not immediately terminate pip_download.py and all
its children. Thus, the script appears to hang.
This patch make pip_download.py to capture SIGINT and pass it as
cancellation event to all threads. It is changed to run with python3.
All flake8 issues are also fixed.
Testing:
- Manually run `buildall.sh -cmake_only` and interrupt it in the middle
of pip_download.py execution. Verify that script terminate
immediately.
Change-Id: I6f293dd8f3fcf3cffa17a4a44627a41d67b7dc91
Reviewed-on: http://gerrit.cloudera.org:8080/22128
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Make pip_download.py interruptible
> ----------------------------------
>
> Key: IMPALA-13585
> URL: https://issues.apache.org/jira/browse/IMPALA-13585
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Minor
>
> infra/python/deps/pip_download.py use multiprocessing.pool.ThreadPool where
> each thread calls wget. It is also wrap the download_package function with
> retry wrapper. When there is a network issue happen, pressing Ctrl+C does not
> immediately terminate pip_download.py and all its children. It should be
> possible to capture SIGINT and pass it as cancellation event to all threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
