[
https://issues.apache.org/jira/browse/IMPALA-13495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896489#comment-17896489
]
ASF subversion and git services commented on IMPALA-13495:
----------------------------------------------------------
Commit d0423a83efa73a42451a5e5c7ac39b43161dd61f in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d0423a83e ]
IMPALA-13495: Make exceptions from the Calcite planner easier to classify
This makes several changes to the Calcite planner to improve the
generated exceptions when there are errors:
1. When the Calcite parser produces SqlParseException, this is converted
to Impala's regular ParseException.
2. When the Calcite validation fails, it produces a CalciteContextException,
which is a wrapper around the real cause. This converts these validation
errors into AnalysisExceptions.
3. This produces UnsupportedFeatureException for non-HDFS table types like
Kudu, HBase, Iceberg, and views. It also produces
UnsupportedFeatureException for HDFS tables with complex types (which
otherwise would hit ClassCastException).
4. This changes exception handling in CalciteJniFrontend.java so it does
not convert exceptions to InternalException. The JNI code will print
the stacktrace for exceptions, so this drops the existing call to
print the exception stack trace.
Testing:
- Ran some end-to-end tests with a mode that continues past failures
and examined the output.
Change-Id: I6702ceac1d1d67c3d82ec357d938f12a6cf1c828
Reviewed-on: http://gerrit.cloudera.org:8080/21989
Reviewed-by: Michael Smith <[email protected]>
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Joe McDonnell <[email protected]>
> Calcite planner: Make exceptions easier to classify
> ---------------------------------------------------
>
> Key: IMPALA-13495
> URL: https://issues.apache.org/jira/browse/IMPALA-13495
> Project: IMPALA
> Issue Type: Sub-task
> Components: Frontend
> Affects Versions: Impala 4.5.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> To make it easier to diagnose what is going on, it would be useful for the
> Calcite planner to produce categorized exceptions like ParseException,
> AnalysisException, etc. It would also be useful to produce a
> UnsupportedFeatureException for things that are not expected to work (e.g.
> HBase, Kudu, views, etc).
> Right now, the Calcite planner converts all exceptions from
> CalciteJniFrontend to InternalException, which makes it harder to classify
> them after the fact.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
