Hi! I performed an AD review of draft-ietf-ipsecme-yang-iptfs-05. Thanks for this complementary work to draft-ietf-ipsecme-iptfs. Feedback is below.
** Section 2. Editorial. s/ipsec/IPsec/ ** Section 2. Typo. s/to fll/to fill/ ** Section 2. Typo? Per "RFC [RFC9061] has a set of ", this strikes me as an odd way to make the reference. Was it supposed to be "RFC 9061 [RFC9061]"? I would recommend "RFC9061 [RFC9061] defines as set of". ** Section 2. Editorial. s/IP-TFS YANG/The IP-TFS YANG module/ ** Section 3.2. Leaf rx-incomplete-pkts. To check my understanding, this is a count of inner packets for which not all of the necessary fragments arrived? ** Section 3.2. Leaf out-packet-size. Please state the units (bytes?). ** Section 5. Please use the YANG security template as a means to be specific about the read and write implications of this module. ** Section 5. IP-TFS hides the traffic flows through the network, anywhere that access YANG statistics is enabled needs to be protected from third party observation. Can this sentence please be restated as is doesn't parse. Is the intent to say that the statistics need to be access controlled? The template references above would help here. ** Section A.*. Editorial. s/ipsec/IPsec/ ** Section A.*. Editorial. s/ikeless/IKE-less/ ** Section A.5. Typo. s/json/JSON/ ** Section A.5. Typo. s/formated/formatted/ ** Section A.5. <tfs:traffic-flow-security> <tfs:reorder-window- size>300</tfs:reorder-window-size> There is an XML fragment at the very end of the document. Is that a typo? Thanks, Roman _______________________________________________ IPsec mailing list IPsec@ietf.org https://www.ietf.org/mailman/listinfo/ipsec
