Hi everyone,
On 04/12/17 15:29, Mats Wichmann wrote: > On 11/30/2017 11:56 PM, ABITHA S wrote: >> Dear All, >> >> I am glad to announce that *RC6* tagging is done on *1.3-rel* branch. >> >> With *1.3.1-RC6* there was a failure related to Random PIN based OTM, which >> has >> been fixed. >> >> Please use 1.3.1-RC6 + patch (https://gerrit.iotivity.org/gerrit/#/c/23505/). good! this fix should be merged to master soon with: https://gerrit.iotivity.org/gerrit/#/c/23479/ (...) > Did anyone check that the generated security dat files are up to date in > the rc? A recent mergeback of 1.3-rel changes to master branch (which > has build logic to regenerate dat files if necessary, Actually they are regenerated on each build/install, and rely on git to spot the differences if any (like you did) > 1.3-rel does not > have such logic), shows a number of them being out of date. Since any > updated files would have been part of the mergeback also, I conclude it > is possible the ones in 1.3-rel are out of date. Indeed, even for master I expected each module maintainer will commit them in master and keep it synced to 1.3-rel if needed. > > Report from master after a build run: > > $ git status -s -uno > M resource/IPCA/unittests/IPCAUnitTest.dat One other explanation could be that master contain a change which is not present on 1.3-rel and does alterate those .dat files. Anyway back to your concerns, I think it should worth, to rebuild .dat files from json using jsontool and commit them to 1.3-rel, and see if they're fine on next mergeback to master. By the way those changes are desirable in 1.3-rel : https://gerrit.iotivity.org/gerrit/#/c/23499/ https://gerrit.iotivity.org/gerrit/#/c/23621/ https://gerrit.iotivity.org/gerrit/#/q/topic:next+status:open Note that some 1.3-rel examples are not working due to missing ACL2 port, so It would be good to start with listed .json files https://jira.iotivity.org/browse/IOT-2338 I can explain more in jira ticket if needed. -- mailto:philippe.co...@osg.samsung.com gpg:0x467094BC https://blogs.s-osg.org/author/pcoval/ _______________________________________________ iotivity-dev mailing list iotivity-dev@lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
