Hi Phil, This request from me for freeze is somewhat out of date at this time, because RC5 tag contains all needed security-related fixes for 1.3.1 final release.
I have noted that 1.3.1 final tag has not been created even though security fixes were done 2 weeks ago. At this time, I am not sure what is happening in other IoTivity areas, but I *think* there are other fixes still ongoing, and there may be a RC6 tag at some point. Abitha, Dwarka or Uze (all cc'd) may know more details. I still think we should be focusing on master for all patches that are not required for CTT fix, but again, that is not my decision alone. At the very least, I think all patches should undergo regression testing against CTT prior to merge, to make sure no new issues are introduced. I have been doing this with any security patches, along with help from Antu. Thanks, Nathan From: iotivity-maintainers-boun...@lists.iotivity.org [mailto:iotivity-maintainers-boun...@lists.iotivity.org] On Behalf Of Philippe Coval Sent: Monday, November 20, 2017 9:12 AM To: iotivity-dev@lists.iotivity.org; iotivity-maintain...@lists.iotivity.org Subject: Re: [Iotivity-maintainers] [dev] request for 1.3-rel code freeze On 05/11/17 01:55, Heldt-Sheller, Nathan wrote: Hi folks, Hi everyone, As we are just about to tag 1.3-rel RC5, good, I've tried to build on various system I am supporting, so far so good, but some may expect problem due to scons versions but it's not a blocker, and I will push most of my pending changes to on master first, and will keep you updated if interested, Don't hesitate to report bugs on tracker it's easier to track when things broke, and do fast bisection. I suggest that ONLY patches that fix certification-blocking issues be merged between now and when we have a 1.3.1 final tag done. So there is no RC6 planned ? I've given a -2 review to many patches that look perfectly fine, along with a comment that I'll remove the -2 as soon as RC5 is done (but I guess I meant to say, as soon as 1.3.1 is tagged). Even very safe changes create a bit of instability and extra work, as all the devs and QA working on finalizing the release have to re-fetch and re-pull and re-build 1.3-rel. Since we are already a few weeks behind schedule for 1.3.1 release, I hope everyone can hang on just a bit before we merge anything more to 1.3-rel. There is a follow-on release planned immediately after 1.3.1, in order to incorporate other very important features, so these patches can go into that release (1.3.2?), too, before we move off of 1.3-rel and onto master for the next major version. For desired "safe changes" may I suggest to add the 'next' label, to make sure it in next version, and it will be noticed by downstream: https://gerrit.iotivity.org/gerrit/#/q/status:open+project:iotivity+topic:next Obviously this isn't my sole judgement call (it's probably Uze's or Abitha's) but I'm suggesting this and hope we can agree. OK for me, I won't merge anything on 1.3-rel unless requested or hard blocking But for master is open for reviews, please have a look at: https://gerrit.iotivity.org/gerrit/#/c/22733/ and then those ones: https://gerrit.iotivity.org/gerrit/#/q/branch:master+status:open+project:iotivity+is:mergeable+AND++NOT+label:Code-Review%253D-1+AND++NOT+label:Code-Review%253D-2++AND+NOT+label:Verified%253D-1 Kind regards and good luck for the final fixes -- mailto:philippe.co...@osg.samsung.com gpg:0x467094BC https://blogs.s-osg.org/author/pcoval/
_______________________________________________ iotivity-dev mailing list iotivity-dev@lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
