Please if you have a stake, or an opinion, weigh in. I spent some time working on the results from the Jenkins builder unit-test task, which now has a component of generating a result from running valgrind memory checker over the tests, and will mark the entire build a fail if there are too many valgrind memory check problems.
The security unit test, which ends up at this path in Jenkins (and my builds) is this file: out/linux/x86_64/debug/resource/csdk/security/unittest/unittest It's been reporting 15 memory leaks which are "definitely lost", plus a few "possibly lost", plus a couple relating to access through an uninitialized pointer. Those issues have been enough to push master changes generally into a failing state - I've sent other emails on this so it should not be news. I put up three distinct fixes which collectively eliminated 9 of the leaks, plus the uninit problem. Some of the leaks are in the unit test code, but some are also in the stack code. These are the three patches: https://gerrit.iotivity.org/gerrit/#/c/22369/ https://gerrit.iotivity.org/gerrit/#/c/22371/ https://gerrit.iotivity.org/gerrit/#/c/22381/ I figured small changes would be simpler to get through, but we've had trouble getting the builds to get a verified vote from Jenkins (only the patch which removed 7 fails passes; the others remain above the limit - which was supposed to be extended, but there was a problem with that as well), I've also combined the three into a single patchset, just to "prove" the combination works. That patch is here: https://gerrit.iotivity.org/gerrit/#/c/22395/ one can see that the fail count that matters to Jenkins has sunk to six "definitely lost" and no uninitialized: https://build.iotivity.org/ci/job/iotivity-verify-unit_tests/18542/valgrindResult/pid=25786/ It would be nice to get reviews on these so they/it can progress (and comment on whether they should be pulled back to 1.3 or not)... it's no difference to me if the three separated ones, or the experimental unified one, is the preferred way forward, and sorry to leave it complicated by having options. _______________________________________________ iotivity-dev mailing list iotivity-dev@lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
