On 10/21/2011 05:48 PM, donotre...@icculus.org wrote:
Author: tma
Date: 2011-10-21 18:48:53 -0400 (Fri, 21 Oct 2011)
New Revision: 2187

Modified: trunk/code/qcommon/common.c
===================================================================
--- trunk/code/qcommon/common.c 2011-10-14 17:03:59 UTC (rev 2186)
+++ trunk/code/qcommon/common.c 2011-10-21 22:48:53 UTC (rev 2187)
@@ -2329,7 +2329,10 @@
  =================
  */
  static void Com_Crash_f( void ) {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnull-dereference"
        * ( int * ) 0 = 0x12345678;
+#pragma clang diagnostic pop
  }
This causes a warning about unknown pragma's in GCC. Would it be better to ifdef __clang__ those?

Speaking of warnings, currently with clang, there's a flood of warnings related to these options not being available in clang: falign-loops=2 -falign-jumps=2 -falign-functions=2 -fstrength-reduce

One option would be to do something like this:
ifeq ($(ARCH),x86_64)
  OPTIMIZEVM = -O3 -fomit-frame-pointer -funroll-loops
  ifneq ("$(CC)", $(findstring "$(CC)", "clang" "clang++"))
    OPTIMIZEVM += -falign-loops=2 -falign-jumps=2 -falign-functions=2 \
                  -fstrength-reduce
  endif
  OPTIMIZE = $(OPTIMIZEVM) -ffast-math
  HAVE_VM_COMPILED = true
else
...

This may not be the most elegant solution, but it's what immediately came to mind.

Anyways, it's really not a big deal either way for either of these changes to be accepted. Just thought I'd mention them :)
_______________________________________________
ioquake3 mailing list
ioquake3@lists.ioquake.org
http://lists.ioquake.org/listinfo.cgi/ioquake3-ioquake.org
By sending this message I agree to love ioquake3 and libsdl.

Reply via email to