Hi Joerg, On 6/23/2022 1:24 PM, Joerg Roedel wrote: > Hi Vasant, > > On Wed, May 11, 2022 at 12:51:06PM +0530, Vasant Hegde wrote: >> .../admin-guide/kernel-parameters.txt | 34 +- >> drivers/iommu/amd/amd_iommu.h | 13 +- >> drivers/iommu/amd/amd_iommu_types.h | 133 +++- >> drivers/iommu/amd/init.c | 687 +++++++++++------- >> drivers/iommu/amd/iommu.c | 563 ++++++++------ >> drivers/iommu/amd/iommu_v2.c | 67 +- >> drivers/iommu/amd/quirks.c | 4 +- >> 7 files changed, 904 insertions(+), 597 deletions(-) > > So this is applied now to the IOMMU tree, thanks for the work. Something > that bothered me while looking at this was the almost complete lack of > locking while accessing the global data structures. Some of them are > lock-less, so it is partially fine, and most of them are used read-only > during system runtime. But I would appreciate if you and/or Suravee > could look over that again and check again if there needs to be more > locking.
Thanks. We did look into the code and we think it should be fine for now. > > The current situation will fire back at the point where you want to > implement IOMMU hotplug. Note that device hotplug is already possible > today, either with real devices or SR-IOV. You are right. We think IOMMU hotplug support needs lot more changes including locking existing global structures. We will look into it whenever we support IOMMU hotplug. -Vasant > > Regards, > > Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
