Hi,
-----Original Message-----
From: David E. Box <david.e....@linux.intel.com>
Sent: 28 October 2020 06:44 PM
To: Shameer Kolothum <shameerali.kolothum.th...@huawei.com>;
linux-arm-ker...@lists.infradead.org; linux-a...@vger.kernel.org;
iommu@lists.linux-foundation.org; de...@acpica.org
Cc: linux...@huawei.com; Lorenzo Pieralisi <lorenzo.pieral...@arm.com>;
j...@8bytes.org; Robin Murphy <robin.mur...@arm.com>; wanghuiqi...@huawei.com;
jonathan.came...@huawei.com
Subject: [Devel] Re: [RFC PATCH 2/4] ACPI/IORT: Add support for RMR node parsing
Hi,
On Tue, 2020-10-27 at 11:26 +0000, Shameer Kolothum wrote:
...
> @@ -1647,6 +1667,100 @@ static void __init iort_enable_acs(struct
> acpi_iort_node *iort_node)
> #else
> static inline void iort_enable_acs(struct acpi_iort_node *iort_node)
> { }
> #endif
> +static int iort_rmr_desc_valid(struct acpi_iort_rmr_desc *desc)
> +{
> + struct iort_rmr_entry *e;
> + u64 end, start = desc->base_address, length = desc->length;
> +
> + if ((!IS_ALIGNED(start, SZ_64K)) || (length % SZ_64K != 0))
You could just do:
if ((!IS_ALIGNED(start, SZ_64K)) || (length % SZ_64K))
[SAMI] In my opinion, the following may be better:
if (!IS_ALIGNED(start, SZ_64K) || !IS_ALIGNED(length, SZ_64K))
[/SAMI]
Regards,
Sami Mujawar
David
_______________________________________________
Devel mailing list -- de...@acpica.org
To unsubscribe send an email to devel-le...@acpica.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
